add fixes from the maxent paper

recursionpharma / gflownet

GFlowNet library specialized for graph & molecular data

MIT License

211 stars 41 forks source link

add fixes from the maxent paper #116

Closed SobhanMP closed 8 months ago

SobhanMP commented 9 months ago

Just in case, please don't merge

SobhanMP commented 9 months ago

Having a generic moo class would be so nice. BTW the moo task did not support having the FR in an order other than the default...

SobhanMP commented 9 months ago

It may be a stupid realization but generate_forward_trajectory is subsumed by sample_backward_from_graphs by setting model=False.

SobhanMP commented 9 months ago

@bengioe is the List[Dict[str, Any]] ok in trajectory_balance.py? mypy complaints otherwise as the inferred type for the list is too restrictive.

SobhanMP commented 9 months ago

things definitely run now