First batch of includes

[yammes08]

• Created four include templates based on a selection of guide profiles
• Removed user-choice scoring sections from includes
• Added these to the includes.json

[yammes08]

@rcdailey - tagging for a general review, but also the YAML Lint checks are failing...have I got something wrong with these, or is it because the rules are expecting a different indentation?

[rcdailey]

Hey yammes, the issue is that everything is indented by 2 spaces from the very left column. You only need to shift everything back 2 spaces and it'll clear up the lint issues.

[rcdailey]

As an example, your current file indentation looks like this:

  quality_definition:
    type: movie

But it needs to shift left by 2 spaces:

quality_definition:
  type: movie

I'm only showing a very small piece for example purposes, but this would apply to the entire file.

[yammes08]

As an example, your current file indentation looks like this:

  quality_definition:
    type: movie

But it needs to shift left by 2 spaces:

quality_definition:
  type: movie

I'm only showing a very small piece for example purposes, but this would apply to the entire file.

I was certain I'd done that already which is why I asked...but no, I'd not done enough...sorry 😄

[yammes08]

Fixed now - does everything else look alright?

[rcdailey]

Seems ok so far! I think where things will be more interesting is when you start including them in templates. We talked a little about this a few days ago, but you could either commit template changes to your fork (and change the config repo URL in your settings.yml) or just create copies in this repo for now so they don't interfere with the stable release.

You could go a number of ways. Did you have a plan already? Or were you just going to manipulate local configs for now to see how they would work if you had created them with config create?

[yammes08]

Seems ok so far! I think where things will be more interesting is when you start including them in templates. We talked a little about this a few days ago, but you could either commit template changes to your fork (and change the config repo URL in your settings.yml) or just create copies in this repo for now so they don't interfere with the stable release.

You could go a number of ways. Did you have a plan already? Or were you just going to manipulate local configs for now to see how they would work if you had created them with config create?

For now, the idea is that I'll locally build 'new-style' templates that reference these includes, and then should they pass testing without issue then I'd look to update the templates themselves in the repo to match what I've built locally.

I've deviated a little from our last discussion on this, and haven't split quality profiles and custom formats into separate sections. For includes that are designed to mirror the guides, I don't think it's necessary.

Edit - just to be explicit about it, I'm going to merge these new includes into the live repo as they won't be 'live operation affecting'.

[rcdailey]

Sounds like a great plan yammes. Good work! I think you'll eventually get a feel for how granular you want your include files as you play around with these more.

[rcdailey]

@yammes08 I went ahead and merged this so we have something to test with.

[yammes08]

@yammes08 I went ahead and merged this so we have something to test with.

No problem, thanks for this, I just didn't get to it.