search

reczoo / FuxiCTR

A configurable, tunable, and reproducible library for CTR prediction https://fuxictr.github.io
Apache License 2.0
914 stars 157 forks source link

FEA: add EulerNet implementation #107

Closed Ethan-TZ closed 2 months ago

CLAassistant commented 2 months ago

CLA assistant check
All committers have signed the CLA.

zhujiem commented 2 months ago

Thanks for the contribution! Review comments:

  1. README conflicts
  2. 本代码仓只维护代码，避免后续版本变更导致执行不一致问题。建议Runing log放在个人目录，在首页表格里添加benchmark链接，或者push到https://github.com/reczoo/BARS/tree/main/ranking/ctr 。
  3. https://github.com/Ethan-TZ/FuxiCTR/blob/main/model_zoo/EulerNet/src/EulerNet.py#L3 表头需要修改copyright信息

我可以直接在你的fork repo里修改吗？

Ethan-TZ commented 2 months ago

@zhujiem 没问题朱老师，要不我按您的意见先改一下，之后麻烦您再check一下～

Ethan-TZ commented 2 months ago

@zhujiem 没问题朱老师，要不我按您的意见先改一下，之后麻烦您再check一下～

已修改完毕

zhujiem commented 2 months ago

Header中 Copyright (C) 2024 salmon@github 这个是对的吗？

Ethan-TZ commented 2 months ago

Header中 Copyright (C) 2024 salmon@github 这个是对的吗？

 不对，已修改