search

red-blox / zap

A lightning fast networking solution for roblox.
https://zap.redblox.dev
MIT License
89 stars 14 forks source link

Remove benign shadowing #104

Closed Ketasaja closed 2 months ago

Ketasaja commented 2 months ago

Suffixes are less incremental than with display_escaped_suffix, but there should be no shadowing left. I'm not aware of this being necessary to fix anything, unlike previous changes.

Ketasaja commented 2 months ago

I kind of dislike the complexity being added here, and I still haven't handled cases like Stmt::LocalTuple or Stmt::Assign.

sasial-dev commented 2 months ago

Maybe let's revert that commit then? I agree it's not the greatest approch to hide it.