red-data-tools / red-datasets

A RubyGem that provides common datasets
MIT License
30 stars 25 forks source link

Prepared for releasing version 0.1.5 #156

Closed otegami closed 1 year ago

otegami commented 1 year ago

What I did

Notes for reviewers

Would you check the contents of news.md? And I really want to add what kou did to news.md but there were a lot of changed I couldn't write.

kou commented 1 year ago

We don't need to add notes for commits that aren't related to users such as expected value update in test. Because this is for users.

kou commented 1 year ago

And I really want to add what kou did to news.md but there were a lot of changed I couldn't write.

Updated.

otegami commented 1 year ago

We don't need to add notes for commits that aren't related to users such as expected value update in test. Because this is for users.

Thank you so much. I've fixed: 374a79c

otegami commented 1 year ago

Thank you for reviewing. I dealt with all of them you pointed so far🙏

kou commented 1 year ago

Thanks!

Could you tell me your https://rubygems.org/ account to release red-datasets gem?

otegami commented 1 year ago

@kou I've just created account. otegami is my RubyGems account.

kou commented 1 year ago

OK. Now, you can release red-datasets gem:

$ git clone git@github.com:red-data-tools/red-datasets.git
$ cd red-datasets
$ rake release
otegami commented 1 year ago

Thank you so much I will try it now!

otegami commented 1 year ago

I've just released v0.1.5 with @kou support.