Open heronshoes opened 1 year ago
Proposal 2 isn't acceptable. We should put all files under datasets/
to avoid conflict.
I don't like common
. If we use datasets/common/
, Datasets::Error
should be renamed to Datasets::Common::Error
, right?
Datasets::Common::Error
is strange for me. I want to use Datasets::Error
as an user.
If someone have a proposal, please share it.
Ah, I didn't think about errors.
Is this work?
lib/
datasets/ # includes common engines
(some_good_name)/ # includes each .rb for datasets
The current
lib/datasets
directory is a mix of .rb files for the common engine and .rb files for the individual datasets.I think separating these would improve the outlook.
Proposal 1:
Proposal 2: