red-data-tools / red-datasets

A RubyGem that provides common datasets
MIT License
30 stars 25 forks source link

Add Mnist Data. #18

Closed rilmayer closed 6 years ago

rilmayer commented 6 years ago

I tried to write code about Mnist(http://yann.lecun.com/exdb/mnist/). I think we will be able to use Mnist Dataset.

rilmayer commented 6 years ago

I am very thankful because I have not had the opportunity to be reviewed the code as usual. I would like to fix if there is something else!

rilmayer commented 6 years ago

Thanks. I fixed where you commented.

rilmayer commented 6 years ago

Sorry for some minor fixes, but I think I could have fixed all where you commented.

rilmayer commented 6 years ago

Thanks, I have fixed the code you commented. Please check my comments for some fix.

kou commented 6 years ago

Thanks! Now, we can use it in Red Chainer for MNIST dataset.

We can work on exception classes as another work.

rilmayer commented 6 years ago

Thank you for having reviewed, and for having merged. I have learned a lot, so I want to commit more.

And Thanks for some fix to my code.

kou commented 6 years ago

Great! We should support more datasets! For example, we can find some target datasets at https://github.com/red-data-tools/red-datasets/issues .