search

red-data-tools / red-datasets

A RubyGem that provides common datasets
MIT License
30 stars 25 forks source link

quora: reduce needless converters #189

Closed tikkss closed 5 months ago

tikkss commented 5 months ago

Because date_time and float are not included in tsv.

Before this change:

$ time ruby -I lib test/run-test.rb -t "/QuoraDuplicateQuestionPairTest/" -v
Loaded suite test
Started
QuoraDuplicateQuestionPairTest:
  test: #each:                                                                                                                  .: (24.666772)

Finished in 24.667106 seconds.
-------------------------------------------------------------------------------------------------------------------------------------------------
1 tests, 1 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
-------------------------------------------------------------------------------------------------------------------------------------------------
0.04 tests/s, 0.04 assertions/s

real    0m25.270s
user    0m24.633s
sys     0m0.451s

After this change:

$ time ruby -I lib test/run-test.rb -t "/QuoraDuplicateQuestionPairTest/" -v
Loaded suite test
Started
QuoraDuplicateQuestionPairTest:
  test: #each:                                                                                                                  .: (17.476536)

Finished in 17.476912 seconds.
-------------------------------------------------------------------------------------------------------------------------------------------------
1 tests, 1 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
100% passed
-------------------------------------------------------------------------------------------------------------------------------------------------
0.06 tests/s, 0.06 assertions/s

real    0m18.117s
user    0m17.554s
sys     0m0.383s

Refs #188.

kou commented 5 months ago

Good catch!

tikkss commented 5 months ago

Thanks for your review!