Closed hatappi closed 6 years ago
@kou Please review my PullRequest.
Thanks. I've merged and am working on some improvements. I'll write summary to this after the work.
I'll do the followings:
InvalidArgument
instead of raw raise
.set_
from set_type
because set_
is redundant. This context is "dataset". So we don't need to specify "set" in this context.It may be better that we keep Record#data
as byte string instead of an array of integer and Record#pixels
returns an array of integer like the followings:
class Record < Struct.new(:data, :label)
def pixels
data.unpack("C*")
end
end
Record#to_gdk_pixbuf
, Record#to_narray
and so on may be useful.
It may be better that we use Dataset::CIFAR
instead of Cifar
because the original dataset name is "CIFAR".
e.g.: HTTP
is better than Http
for "HTTP".
The usage in this pull request description is useful information. So we should put it to README.md or document comment in the source.
@kou Thank you for comment. I will do the following.
add CIFAR-10, 100 datasets.
Usage
CIFAR1-10
CIFAR1-100