red-data-tools / unicode_plot.rb

Plot your data by Unicode characters
MIT License
246 stars 12 forks source link

Add changelog auto detection in workflows please #21

Closed schneems closed 3 years ago

schneems commented 4 years ago

1) Click "Actions" 2) Navigate to make a manual action 3) name the file something like "check_changes.yml"

Put in this config:

name: Check Changelog

on: [pull_request]

jobs:
  build:
    runs-on: ubuntu-latest
    steps:
    - uses: actions/checkout@v1
    - name: Check that CHANGELOG is touched
      run: |
        cat $GITHUB_EVENT_PATH | jq .pull_request.title |  grep -i '\[\(\(changelog skip\)\|\(ci skip\)\)\]' ||  git diff remotes/origin/${{ github.base_ref }} --name-only | grep CHANGES.md

This requires that all PRs touch the changelog or have CI SKIP or CHANGELOG SKIP in the PR title. That way your changelog is already filled out when you go to release a new version instead of having to manually go back and add it.

mrkn commented 4 years ago

Thank you for your feedback. But, I think this isn't necessary for this project.

@kou How do you think?

kou commented 4 years ago

I think this isn't necessary too.

schneems commented 3 years ago

Thank you for reviewing the issue. I find this helps to make contributing faster in this scenario:

It also reduces the errors of this scenario: