search

red-data-tools / unicode_plot.rb

Plot your data by Unicode characters
MIT License
246 stars 12 forks source link

Lineplot has a limited number of colors to choose from. #34

Open kojix2 opened 3 years ago

kojix2 commented 3 years ago

Barplot

UnicodePlot.lineplot([2,3,4],[5,6,7], title: "Bar", color: 32).render

OK.

Lineplot

UnicodePlot.lineplot([1,2,3], [4,5,8], color: 32).render

Error

        9: from /Library/Ruby/Gems/2.6.0/gems/unicode_plot-0.0.4/lib/unicode_plot/lineplot.rb:40:in `lineplot'
        8: from /Library/Ruby/Gems/2.6.0/gems/unicode_plot-0.0.4/lib/unicode_plot/lineplot.rb:85:in `lineplot!'
        7: from /Library/Ruby/Gems/2.6.0/gems/unicode_plot-0.0.4/lib/unicode_plot/grid_plot.rb:93:in `lines!'
        6: from /Library/Ruby/Gems/2.6.0/gems/unicode_plot-0.0.4/lib/unicode_plot/canvas.rb:159:in `lines!'
        5: from /Library/Ruby/Gems/2.6.0/gems/unicode_plot-0.0.4/lib/unicode_plot/canvas.rb:159:in `each'
        4: from /Library/Ruby/Gems/2.6.0/gems/unicode_plot-0.0.4/lib/unicode_plot/canvas.rb:160:in `block in lines!'
        3: from /Library/Ruby/Gems/2.6.0/gems/unicode_plot-0.0.4/lib/unicode_plot/canvas.rb:143:in `line!'
        2: from /Library/Ruby/Gems/2.6.0/gems/unicode_plot-0.0.4/lib/unicode_plot/braille_canvas.rb:49:in `pixel!'
        1: from /Library/Ruby/Gems/2.6.0/gems/unicode_plot-0.0.4/lib/unicode_plot/braille_canvas.rb:49:in `|'
TypeError (nil can't be coerced into Integer)
kojix2 commented 3 years ago

Awosome! @nanobowers

nanobowers commented 3 years ago

Hi @mrkn and @kojix2 , I think that getting proper support for 256 colors (and 24-bit) is necessary to fix this issue and to support heatmap plots (#29 ). As discussed in #36 , supporting numeric 256 colors without color mixing is insufficient.

per #29 :

We need to use https://github.com/red-data-tools/red-colors and https://github.com/red-data-tools/red-palette to implement colormap used in heatmap because this library is a backend of https://github.com/red-data-tools/charty.

I have looked some at red-colors and red-palette. I understand the reason to use them, but as they exist I believe they may be insufficient for handling ANSI colors without adding features from something like: https://github.com/janlelis/paint/blob/main/lib/paint.rb

Specifically, we need a way to detect or specify either 8/16/256/24-bit color modes, and support the conversion of color-spaces (e.g. RGB: "#C0FEFE") to/from the appropriate ANSI codes in any of the above color-modes. Some of this is part of red-colors, but some is not (Or I did not see it). Apparently 256 / 24-bit detection is not always easy due to differences in terminals and this can be hard to do well (e.g. differences in Mac vs. Linux, etc)

In any event, i believe there needs to be a decision on how to either

mrkn commented 3 years ago

I've create a pull-request to add Colors::Xterm256 in red-colors gem. I'll add color blending support in red-colors gem later.

We need to define how to blend the ANSI 16 colors and xterm's 256 colors in unicode_plot gem. In other words, we need to discuss how to support user-defined palette of ANSI 16 colors.

I think we can start without supporting user-defined ANSI 16 colors palette, but there are two options in this case:

  1. Use the orthodox palette for ANSI 16 colors.
  2. Forbid to blend ANSI 16 colors and xterm's 256 colors.
nanobowers commented 3 years ago

@mrkn I am now running into this issue in trying to enable heatmap support. For heatmap, storing the colors as Colors::RGB objects is preferable compared to a single integer. This way the renderer can choose between output of xterm256 color or 24-bit output.

As you mention, it is unclear what to do here with regard to existing 16-color ansi support, especially with blending - one option I thought of is

The other thought I have is that with the lineplot case, the blending would happen successively and depending on the blending algorithm you may get different results. E.g. if the mixing used averaging applied in series, for one ordering of Red color data, would get average(average(130,70), 170) = 135, whereas another ordering average(average(130,170),70) = 110 Perhaps the blending would use max() which is not order dependent?

kojix2 commented 3 years ago

So this issue is still going on...

nanobowers commented 3 years ago

@kojix2 I believe this is waiting on this pr: https://github.com/red-data-tools/red-colors/pull/13 Sadly, I forgot to mention this earlier.

mrkn commented 3 years ago

@nanobowers Thank you for reminding your pull-request.

@kojix2 As I mention in the pull-request, I need more time to find the appropriate distance function for deciding closest color.

mrkn commented 3 years ago

Moreover, we need to decide how to blend two or more colors. Maybe we need a way to specify the terminal background color.