search

red-data-tools / unicode_plot.rb

Plot your data by Unicode characters
MIT License
246 stars 12 forks source link

New features #35

Closed nanobowers closed 3 years ago

nanobowers commented 3 years ago

@mrkn This PR Adds support for

tests included for both stair plots and block canvas which were mostly borrowed from UnicodePlots.jl tests

Also contains issue fixes for

I have also included more examples in the examples directory. Some of them are for getting a quick start for users. Others are exposing issues #32/#34, which may want to eventually either be turned into unit test cases or removed.

If you would like separated PRs for each issue (#17, #19, #32, #34) then please let me know. Thanks!

mrkn commented 3 years ago

@nanobowers Thanks for submitting this pull-request. At first, I will decompose this pull-request into small ones that consist of independent single features. Then I will look at them to review the code.

mrkn commented 3 years ago

@nanobowers

If you would like separated PRs for each issue (#17, #19, #32, #34) then please let me know. Thanks!

Oh, I missed this sentence. It's very helpful to me. Could you please separate this pull-request?

nanobowers commented 3 years ago

separated into separate PRs for