red-hat-data-services / odh-deployer

The odh-deployer image creates a custom resource for the image in operator image in odh-operator-allinone
Apache License 2.0
5 stars 42 forks source link

Add modelmesh cred secrets. #287

Closed HumairAK closed 1 year ago

HumairAK commented 1 year ago

Description

Add auth to etcd.

Part of:

Testing instructions:

  1. ./setup.sh quay.io/hukhan/rhods-operator-live-catalog:1.20.1-5451
  2. Confirm that the following secrets are created by the odh-deployer:
oc -n redhat-ods-applications get secret model-serving-etcd -o jsonpath='{.data.etcd_connection}' | base64 -d
oc -n redhat-ods-applications get secret etcd-passwords -o jsonpath='{.data.root}' | base64 -d

The passwords in both secrets should match. One is used by etcd to create the root user, the other is used by MM to access etcd as this same user.

  1. Wait for the modelmesh monitoring stack pods to come up
  2. Clone https://github.com/opendatahub-io/modelmesh-serving/tree/main/quickstart.
  3. Comment out lines 32 and 33.
  4. ./quickstart.sh. Wait for the script to finish runnning
  5. Test MM infer route to confirm it works.
  6. Update the value of password field in secret model-serving-etcd in redhat-ods-applications, so that it is different than the one in the secret etcd-passwords. Recreate the serving run time:
oc delete -f openvino-inference-service.yaml -f openvino-serving-runtime.yaml 
./quickstart.sh
  1. The modelmesh runtime pods will fail to boot up because they have the incorrect credentials to etcd.

Merge criteria:

HumairAK commented 1 year ago

Incorporates: https://github.com/red-hat-data-services/odh-deployer/pull/279/files

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anishasthana

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/red-hat-data-services/odh-deployer/blob/main/OWNERS)~~ [anishasthana] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment