red-hat-data-services / odh-deployer

The odh-deployer image creates a custom resource for the image in operator image in odh-operator-allinone
Apache License 2.0
5 stars 42 forks source link

Update Serving Runtime Config #302

Closed lucferbux closed 1 year ago

lucferbux commented 1 year ago

Description

How Has This Been Tested?

Follow up of #301

  1. Deploy the operator
  2. Check that a new configmap called servingruntimes-config its created with a key called default-config

Merge criteria:

VaishnaviHire commented 1 year ago

/lgtm

lucferbux commented 1 year ago

I have tested the changes, it's creating the configmap with the openvino image:

    - name: ovms
      image: quay.io/rmartine/odh-openvino-servingruntime-live:1.22.0-1
pablofelix commented 1 year ago

/lgtm

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pablofelix Once this PR has been reviewed and has the lgtm label, please ask for approval from lucferbux by writing /assign @lucferbux in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/red-hat-data-services/odh-deployer/blob/rhods-1.21/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment