remove etcd secret creation from odh-deployer

VedantMahabaleshwarkar commented 1 year ago

Description

This PR, along with this and this are meant to be tested together. Together, they address RHODS-7487. etcd secret creation is moved from odh deployer to etcd initContainer.

How Has This Been Tested?

Created Livebuilder image with changes from all 3 PRs and tested the intended behavior

Merge criteria:

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[x] For commits that came from upstream, [UPSTREAM] has been prepended to the commit message.
[x] JIRA link(s):
[x] The Jira story is acked.
[x] Live build image:
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work.
[x] QE contact acknowledges that this has been tested and is approved for merge.

Testing Instructions

Install quay.io/vedantm/rhods-operator-live-catalog:1.24.0-etcd
Look at odh-deployer logs
- search logs for secret/etcd-passwords and secret/model-serving-etcd created. result should be empty
- in redhat-ods-applications look for the etcd pod
- etcd Pod should have an initContainer with logs for 2 secrets created

heyselbi commented 1 year ago

tested and worked as expected

heyselbi commented 1 year ago

/lgtm

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anishasthana

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/red-hat-data-services/odh-deployer/blob/main/OWNERS)~~ [anishasthana] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

red-hat-data-services / odh-deployer