Add DSP Application recording rules and scrape configs

DharmitD commented 1 year ago

Adding Prometheus configuration and recording rules for Data Science Pipelines' Application.

Description

Using olminstall, trigger first a clean build with the image quay.io/rhn_support_ddalvi/rhods-operator-live-catalog:1.25.0-rhods-7876. Make sure that the installation is successful
Go to the prometheus instance url in the redhat-ods-monitoring namespace, query the recording rules, make sure that they return entries and values relevant to the data science pipelines' application

How Has This Been Tested?

Merge criteria:

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[ ] For commits that came from upstream, [UPSTREAM] has been prepended to the commit message.
[x] JIRA link(s): https://issues.redhat.com/browse/RHODS-7876
[x] The Jira story is acked.
[x] Live build image: quay.io/rhn_support_ddalvi/rhods-operator-live-catalog:1.25.0-rhods-7876
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work.
[ ] QE contact acknowledges that this has been tested and is approved for merge.

harshad16 commented 1 year ago

/retest

jgarciao commented 1 year ago

I've installed livebuild http://quay.io/rhn_support_ddalvi/rhods-operator-live-catalog:1.25.0-rhods-7876 in a cluster and, after creating a DataSciencePipelineApplication, I was able to see the metrics with the query {job="Data Science Pipelines Application"}

I have a question related to this PR that I've asked in this slack thread

livebuild-pr-320-20230414-data-science-pipeline-app-metrics

HumairAK commented 1 year ago

/approve

HumairAK commented 1 year ago

the new change is just a rebase after #314 was merged, re-adding labels:

/lgtm /approve

openshift-ci[bot] commented 1 year ago

@HumairAK: The label(s) `/label qe-approve

cannot be applied. These labels are supported:platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, downstream-change-needed, rebase/manual, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, staff-eng-approved. Is this label configured underlabels -> additional_labelsorlabels -> restricted_labelsinplugin.yaml`?

In response to [this](https://github.com/red-hat-data-services/odh-deployer/pull/320#issuecomment-1508936422): >the new change is just a rebase after #314 was merged, re-adding labels: > >/lgtm >/approve >/label qe-approve > >(based on @jgarciao's lgtm above). Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK, jgarciao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/red-hat-data-services/odh-deployer/blob/main/OWNERS)~~ [HumairAK] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

red-hat-data-services / odh-deployer