Use sha images for all dspo images.

red-hat-data-services / odh-deployer

The odh-deployer image creates a custom resource for the image in operator image in odh-operator-allinone

Apache License 2.0

5 stars 42 forks source link

Use sha images for all dspo images. #321

Closed HumairAK closed 1 year ago

HumairAK commented 1 year ago

Description

For disconnected installs we need to use only sha images, and not tags.

How Has This Been Tested?

Live builder image: quay.io/hukhan/rhods-operator-live-catalog:1.25.0-sha-1-25 Depoy rhods via live builder, deploy DSPA, create a run.

Merge criteria:

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[x] For commits that came from upstream, [UPSTREAM] has been prepended to the commit message.
[x] JIRA link(s):
- https://issues.redhat.com/browse/RHODS-7916
[ ] The Jira story is acked.
[x] Live build image: quay.io/hukhan/rhods-operator-live-catalog:1.25.0-sha-1-25 (upstream_source.yaml)
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work.
[] QE contact acknowledges that this has been tested and is approved for merge.

HumairAK commented 1 year ago

~live build is not right, fixing it, will provide a new one in a bit~

Fixed live build image, it is now up to date, you will see sha images embedded in the kfdef.

zdtsw commented 1 year ago

we can hold this one for a while, till re-enable dspo, ref #324 324

HumairAK commented 1 year ago

@zdtsw since we're targeting dspo for 1.26, can we approve this?

zdtsw commented 1 year ago

/lgtm

HumairAK commented 1 year ago

@jgarciao

jgarciao commented 1 year ago

@HumairAK I've tried to install the livebuild at quay.io/hukhan/rhods-operator-live-catalog:1.25.0-sha-1-25 but the deployer is crashing with this error:

error: unable to recognize "odh-dashboard/apps-managed-service": no matches for kind "ConsoleQuickStart" in version ""

I've seen the same error in other livebuilds last week. Is there any way to fix it without creating a new livebuild?

If not, given the changes in this PR I think it could be merged and be verified with the pre-RC build

HumairAK commented 1 year ago

@jgarciao I think the issue might be due to this:

https://github.com/red-hat-data-services/odh-deployer/commit/45d7c78292a46424493fa5f97add5698f504726f

which looks like it may have been fixed, I'll try to get a new live build and see if it's fixed

If not, given the changes in this PR I think it could be merged and be verified with the pre-RC build

If it's okay with you, I agree with this as the changes are pretty minimal. I'll let you decide :)

HumairAK commented 1 year ago

@jgarciao you can also try the live build here: https://github.com/red-hat-data-services/odh-manifests/pull/339#issuecomment-1509067905

this build incorporates changes from both PRs (you can test both simultaneously)

HumairAK commented 1 year ago

/label qe-approved

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anishasthana, jgarciao, zdtsw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/red-hat-data-services/odh-deployer/blob/main/OWNERS)~~ [anishasthana] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

VaishnaviHire commented 1 year ago

@HumairAK Is this something that needs to be cherry-picked to 1.26?

zdtsw commented 1 year ago

@HumairAK Is this something that needs to be cherry-picked to 1.26?

should already on release branch