Closed starburst-blumbert closed 1 year ago
Can one of the admins verify this patch?
Hi Lucas,
I thought I had removed that file before submitting the PR, but I guess not. I am out of town for the next week, so I won’t be able to remove the file until I get back on the 18th.
Regards, Ben
On Wed, Apr 12, 2023 at 8:51 AM Lucas Fernandez @.***> wrote:
@.**** requested changes on this pull request.
On odh-dashboard/apps-on-prem/.DS_Store https://github.com/red-hat-data-services/odh-deployer/pull/323#discussion_r1164090673 :
@starburst-blumbert https://github.com/starburst-blumbert can you remove this file? it's an internal macos file and it seems we don't have that added to gitignore 😅
— Reply to this email directly, view it on GitHub https://github.com/red-hat-data-services/odh-deployer/pull/323#pullrequestreview-1381250041, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQ62EEGGEMFZHF34YGRUZQLXA2QNDANCNFSM6AAAAAAW22KBLU . You are receiving this because you were mentioned.Message ID: @.***>
--
Ben Lumbert
Partner Solutions Architect
he/him
517-410-7814 @.***
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: lucferbux
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Added folder and supporting files for Starburst Enterprise tiles in RHODS.
Description
Added a new folder in "apps-on-prem" to hold the YAML for the Starburst Enterprise tiles. Added the following YAML files to create Starburst Enterprise tiles:
How Has This Been Tested?
Yes, the tiles have been previewed on an OpenShift cluster to ensure they are displaying as expected, that all text is correct and that all links are valid.
Merge criteria:
[UPSTREAM]
has been prepended to the commit message.