Advertise TensorFlow support in OVMS 2022.3+

red-hat-data-services / odh-deployer

The odh-deployer image creates a custom resource for the image in operator image in odh-operator-allinone

Apache License 2.0

5 stars 42 forks source link

Advertise TensorFlow support in OVMS 2022.3+ #343

Closed Xaenalt closed 1 year ago

Xaenalt commented 1 year ago

Adds the tag to the servingruntime to show TF support

[X] The commits are squashed in a cohesive manner and have meaningful messages.
[X] For commits that came from upstream, [UPSTREAM] has been prepended to the commit message.
[X] JIRA link(s): https://issues.redhat.com/browse/RHODS-8874
[X] The Jira story is acked.
[X] Live build image:
[X] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[X] The developer has manually tested the changes and verified that the changes work.
[X] QE contact acknowledges that this has been tested and is approved for merge.

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign lavlas for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/red-hat-data-services/odh-deployer/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

lucferbux commented 1 year ago

Oh nice, ONNX is supporting tensorflow noww? That's great! Should I adapt https://github.com/red-hat-data-services/odh-deployer/pull/340 to add this into the gpu OOTB?

Xaenalt commented 1 year ago

s/ONNX/OVMS/ but yes, this should be there ootb

lucferbux commented 1 year ago

s/ONNX/OVMS/ but yes, this should be there ootb

Perfect, I'm adding it too, thanks!

lucferbux commented 1 year ago

wait, @Xaenalt I'm changing the name of the files in https://github.com/red-hat-data-services/odh-deployer/pull/340/files Would you mind to close this issue and I'll add tensorflow in my prs?

lucferbux commented 1 year ago

Added in this commit: https://github.com/red-hat-data-services/odh-deployer/pull/340/commits/fe33221e4e034359469c211c92355d1f035922e8

Xaenalt commented 1 year ago

Closing as superceded by https://github.com/red-hat-data-services/odh-deployer/pull/340