Fix issue deploying starbust

red-hat-data-services / odh-deployer

The odh-deployer image creates a custom resource for the image in operator image in odh-operator-allinone

Apache License 2.0

5 stars 42 forks source link

Fix issue deploying starbust #344

Closed lucferbux closed 1 year ago

lucferbux commented 1 year ago

Description

Fix issue with starbust deployment on prem

How Has This Been Tested?

No testing provided, please someone verify this

Merge criteria:

[X] The commits are squashed in a cohesive manner and have meaningful messages.
[ ] For commits that came from upstream, [UPSTREAM] has been prepended to the commit message.
[X] JIRA link(s): https://issues.redhat.com/browse/RHODS-6940
[X] The Jira story is acked.
[ ] Live build image:
[ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[ ] The developer has manually tested the changes and verified that the changes work.
[ ] QE contact acknowledges that this has been tested and is approved for merge.

lucferbux commented 1 year ago

@bdattoma Can you take a look, not sure what acks it needs

lucferbux commented 1 year ago

@anishasthana @VaishnaviHire @LaVLaS could you check this out? I'm aiming to merge this before feature freeze, thanks in advance!

zdtsw commented 1 year ago

@anishasthana @VaishnaviHire @LaVLaS could you check this out? I'm aiming to merge this before feature freeze, thanks in advance!

Can we get this reviewed by this week so we can build it next Monday? Thanks!

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: zdtsw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/red-hat-data-services/odh-deployer/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment