Fix startbust enablement when installing operator

red-hat-data-services / odh-deployer

The odh-deployer image creates a custom resource for the image in operator image in odh-operator-allinone

Apache License 2.0

5 stars 42 forks source link

Fix startbust enablement when installing operator #360

Closed lucferbux closed 1 year ago

lucferbux commented 1 year ago

Description

Fix issue when installing starbust enterprise the app didn't appear as enabled.

How Has This Been Tested?

Install startbus enterprise operator
Check that the app has been enabled

Merge criteria:

[X] The commits are squashed in a cohesive manner and have meaningful messages.
[ ] For commits that came from upstream, [UPSTREAM] has been prepended to the commit message.
[X] JIRA link(s): https://issues.redhat.com/browse/RHODS-9327
[X] The Jira story is acked.
[X] Live build image: quay.io/lferrnan/rhods-operator-live-catalog:1.28.0-deployer
[X] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[X] The developer has manually tested the changes and verified that the changes work.

lucferbux commented 1 year ago

@bdattoma It would be nice to confirm this with Karl, we don't need to add this logic to starburst for managed right?

bdattoma commented 1 year ago

managed

when you say "managed", are you referring to Managed Starburst or Managed RHODS? if you refer to Managed RHODS, I think it is not needed because Starburst Galaxy cannot be enabled in the cluster, it's an external service. What we could do is to add the "Enable" button like it was done for RHOSAK, which would not be a real installation, just a way to make it appearing in "Enabled" page of RHODS.

if you were referring to Managed Starburst, then yes we will need to add the same logic, but for now there is no tile for it in RHODS.

PM should give a final call on both the points.

lucferbux commented 1 year ago

managed

when you say "managed", are you referring to Managed Starburst or Managed RHODS? if you refer to Managed RHODS, I think it is not needed because Starburst Galaxy cannot be enabled in the cluster, it's an external service. What we could do is to add the "Enable" button like it was done for RHOSAK, which would not be a real installation, just a way to make it appearing in "Enabled" page of RHODS.

if you were referring to Managed Starburst, then yes we will need to add the same logic, but for now there is no tile for it in RHODS.

PM should give a final call on both the points.

Yeah, I'm sorry, terminology is quite tricky, I was talking about Manage RHODS, meaning the Starbust Galaxy deployment. I was specifically asking if we should add something to that app resource.

But we might wanna add the enable mechanism that you refer. we can hop back to the slack conversation just to confirm this.

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zdtsw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/red-hat-data-services/odh-deployer/blob/main/OWNERS)~~ [zdtsw] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment