Remove tensorflow from the supported runtimes in OOTB Serving Runtimes

lucferbux commented 1 year ago

Description

Based on the outcome of https://issues.redhat.com/browse/RHODS-8874 it seems that ovms is not supporting tensorflow as previously suggested.

Removing the runtime selection for the OOTB models.

How Has This Been Tested?

Deploy the runtimes with oc apply -k odh-dashboard/modelserving
Deploy a new model
Select OOTB Serving Runtime
Check that the Serving Runtime doesn't include tensorflow

@lugi0 I haven't tested the upgrade, I'll try to do it on Monday, I'm working in other things.

Merge criteria:

[X] The commits are squashed in a cohesive manner and have meaningful messages.
[ ] For commits that came from upstream, [UPSTREAM] has been prepended to the commit message.
[ ] JIRA link(s):
[ ] The Jira story is acked.
[ ] Live build image:
[X] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[X] The developer has manually tested the changes and verified that the changes work.
[ ] QE contact acknowledges that this has been tested and is approved for merge.

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from lucferbux. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/red-hat-data-services/odh-deployer/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

Xaenalt commented 1 year ago

We did eventually find the model that was working with TF support, https://storage.googleapis.com/download.tensorflow.org/models/tflite/model_zoo/upload_20180427/inception_resnet_v2_2018_04_27.tgz

That being said, it does seem compatibility for TF is very narrow, maybe we should list it as tech preview or something in the UI instead

lucferbux commented 1 year ago

I'm gonna close this PR then, we don't have the ability to mark runtimes with labels, but it should be a good idea, I'm gonna ask Jeff if that's something we might wanna be interested in.

red-hat-data-services / odh-deployer