red-hat-data-services / rhoai-disconnected-install-helper

rhods-disconnected-install-helper
GNU General Public License v3.0
8 stars 14 forks source link

Consider add an additional flag to handle RHOAIENG-3873 #44

Open chizhang21 opened 5 months ago

chizhang21 commented 5 months ago

Env:

Ubuntu 20.04

Background:

Using this repo to get the specific version's ImageSetConfiguration for install RHOAI in a disconnected environment.

Issue:

When I try to run command:

bash ./rhods-disconnected-helper.sh -v <version>

besides the specified version's check process (clone repos and verify images) executed, the script also unconditionally executes the same process for the rhoai-main(will significantly increase the script's running time and increase the API request frequency.).

This behavior is redundant if the goal is to obtain the specific version's ImageSetConfiguration YAML file only. I noticed that this issue was introduced by this PR: https://github.com/red-hat-data-services/rhoai-disconnected-install-helper/pull/43

Would you consider adding an additional flag to handle this logic to avoid the unnecessary process?