search

red-hat-storage / ceph-qe-scripts

Various QE scripts written by QE for Ceph Testing
MIT License
10 stars 29 forks source link

TFA, fixing the KeyError download_object_at_remote_site #547

Closed viduship closed 8 months ago

viduship commented 8 months ago

TFA, fixing the KeyError download_object_at_remote_site https://issues.redhat.com/browse/RHCEPHQE-12929

passed log

http://magna002.ceph.redhat.com/cephci-jenkins/cephci-run-SRBFHV http://magna002.ceph.redhat.com/cephci-jenkins/cephci-run-K9BBWP http://magna002.ceph.redhat.com/cephci-jenkins/cephci-run-SIYUWK

viduship commented 8 months ago

IMO, Instead of passing value to download_object_at_remote_site: false in all the configs, Please go with below approach, in a script file instead of : if config.test_ops["download_object_at_remote_site"] is True: go with: if config.test_ops.get("download_object_at_remote_site", False):

Oh yeah, makes sense. Thanks @ckulal

openshift-ci[bot] commented 8 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: anrao19, hmaheswa, mkasturi18, viduship

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/red-hat-storage/ceph-qe-scripts/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment