red-hat-storage / ceph-qe-scripts

Various QE scripts written by QE for Ceph Testing
MIT License
10 stars 29 forks source link

Fix failure seen with mfa testcase #561

Closed ckulal closed 7 months ago

ckulal commented 8 months ago

We were seeing issue: cannot unpack non-iterable NoneType object when put operation of MFA and version enabled is succeeded in the first iteration.

since previously we were returning : return token, mfa_version_put only in case of the situation where put mfa is a failure: i.e if mfa_version_put is False: return token, mfa_version_put

but we are checking condition: if status is False: https://github.com/red-hat-storage/ceph-qe-scripts/pull/561/files#diff-e65bb0e4957600e7835ff2af409a6e7bff1c9e1cbc5dd3ad2124b41a6b91d0deL149

so if mfa version enable i s successful in first attempt it was not returning any value , but in the script we are looking for the condition check fail log: http://magna002.ceph.redhat.com/ceph-qe-logs/Chaithra/mfa-failure/test_rgw_mfa.console.log2-fail

Post fix: Pass log: http://magna002.ceph.redhat.com/ceph-qe-logs/Chaithra/mfa-failure/test_rgw_mfa.console.log5-pass(where mfs enable success in first attempt) http://magna002.ceph.redhat.com/ceph-qe-logs/Chaithra/mfa-failure/test_rgw_mfa.console.log3-pass

http://magna002.ceph.redhat.com/ceph-qe-logs/Chaithra/mfa-failure/test_rgw_mfa.console.log4-pass (where mfs enable success in second attempt)

openshift-ci[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: anrao19, ckulal, mkasturi18

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/red-hat-storage/ceph-qe-scripts/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment