red-hat-storage / errata-tool

Modern Python API to Red Hat's Errata Tool
MIT License
31 stars 34 forks source link

revert _username handling and replace requests-kerberos with requests-gssapi #217

Closed ktdreyer closed 3 years ago

ktdreyer commented 3 years ago

Remove the username discovery in connector.py. The self._username property is not easy to support with the switch from python-kerberos to python-gssapi.

requests-kerberos is not well-maintained upstream and Fedora is dropping it entirely. requests-gssapi is an up-to-date replacement.

Fixes: #135

ktdreyer commented 3 years ago

@lhh , FYI this removes the self._username code you added a while back. I think that's safe to remove since it's marked private with an underscore.

ktdreyer commented 3 years ago

I'll plan to merge this Monday and tag a new release at that time.

ktdreyer commented 3 years ago

I've tagged and pushed v1.24.0 with this change.