search

red-hat-storage / ocs-ci

https://ocs-ci.readthedocs.io/en/latest/
MIT License
109 stars 166 forks source link

In the function "generate_new_nodes_and_osd_running_nodes_ipi" wait for the new OSD node rack or zone to be ready #10534

Open yitzhak12 opened 2 weeks ago

yitzhak12 commented 2 weeks ago

In the function generate_new_nodes_and_osd_running_nodes_ipi, wait for the new OSD node rack or zone to be ready. See the failure: https://reportportal-ocs4.apps.ocp-c1.prod.psi.redhat.com/ui/#ocs/launches/738/24258/1177912/1177946/log. We should add this code

sample = TimeoutSampler( timeout=timeout, sleep=10, func=is_node_rack_or_zone_exist, node_name=new_node_name, failure_domain=failure_domain, ) assert sample.wait_for_func_status( result=True ), f"Didn't find the node rack/zone after {timeout} seconds"

or similar in the function generate_new_nodes_and_osd_running_nodes_ipi here: https://github.com/red-hat-storage/ocs-ci/blob/master/ocs_ci/ocs/node.py#L2909

yitzhak12 commented 2 weeks ago

In addition, we should add the line node_obj.reload() in the first line of the function get_node_rack_or_zone: https://github.com/red-hat-storage/ocs-ci/blob/master/ocs_ci/ocs/node.py#L2032 to reload the node object with the new data. See the related failure here: https://reportportal-ocs4.apps.ocp-c1.prod.psi.redhat.com/ui/#ocs/launches/738/25000/1212457/1212492/log.