red-hat-storage / ocs-operator

Operator for RHOCS

Apache License 2.0

85 stars 184 forks source link

Migrate odf-info structs to API folder #2698

Closed raaizik closed 3 months ago

raaizik commented 3 months ago

Changes

Converts odf-info structs into its own API

2440

openshift-ci[bot] commented 3 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

raaizik commented 3 months ago

/cc @umangachapagain @nb-ohad

rewantsoni commented 3 months ago

/lgtm

nb-ohad commented 3 months ago

A couple of points:

As suggested by @umangachapagain in an offline discussion. A better name for the file containing the new type would be odfinfo_config.go. Mainly because the _type suffix is usually reserved for k8s API types.
This is a new API and we have no indication of its stability. It is better we have it in the v1alpha1 folder
The second commit seems unrelated to this change and I would request to separate it into its own PR

raaizik commented 3 months ago

A couple of points:

* As suggested by @umangachapagain in an offline discussion. A better name for the file containing the new type would be `odfinfo_config.go`. Mainly because the `_type` suffix is usually reserved for k8s API types.

* This is a new API and we have no indication of its stability. It is better we have it in the v1alpha1 folder

* The second commit seems unrelated to this change and I would request to separate it into its own PR

Done @nb-ohad

raaizik commented 3 months ago

/test ocs-operator-bundle-e2e-aws

nb-ohad commented 3 months ago

/lgtm

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nb-ohad, raaizik, rewantsoni

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/red-hat-storage/ocs-operator/blob/main/OWNERS)~~ [nb-ohad] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment