search

red-hat-storage / ocs-operator

Operator for RHOCS
Apache License 2.0
86 stars 184 forks source link

external: enable log rotation and log collection for external mode #2702

Closed parth-gr closed 1 month ago

parth-gr commented 1 month ago

with 4.17 csi pods will be collecting logs by the log rtoation setting, so even if its external mode turn on the log collector setting

parth-gr commented 1 month ago

/cherry-pick 4.17

parth-gr commented 1 month ago

/assign @malayparida2000 @iamniting

malayparida2000 commented 1 month ago

Changes look good but please take a look at the failing unit test due to the change of function signature of newExternalCephCluster function.

parth-gr commented 1 month ago

Changes look good but please take a look at the failing unit test due to the change of function signature of newExternalCephCluster function.

Done

parth-gr commented 1 month ago

Can you look at the failures?

Fixed, there were more places where the cephcluster was called

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, malayparida2000, parth-gr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/red-hat-storage/ocs-operator/blob/main/OWNERS)~~ [iamniting] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-cherrypick-robot commented 1 month ago

@parth-gr: cannot checkout 4.17: error checking out "4.17": exit status 1 error: pathspec '4.17' did not match any file(s) known to git

In response to [this](https://github.com/red-hat-storage/ocs-operator/pull/2702#issuecomment-2236442863): >/cherry-pick 4.17 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.