Closed parth-gr closed 1 month ago
/cherry-pick 4.17
/assign @malayparida2000 @iamniting
Changes look good but please take a look at the failing unit test due to the change of function signature of newExternalCephCluster function.
Changes look good but please take a look at the failing unit test due to the change of function signature of newExternalCephCluster function.
Done
Can you look at the failures?
Fixed, there were more places where the cephcluster was called
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: iamniting, malayparida2000, parth-gr
The full list of commands accepted by this bot can be found here.
The pull request process is described here
@parth-gr: cannot checkout 4.17
: error checking out "4.17": exit status 1 error: pathspec '4.17' did not match any file(s) known to git
with 4.17 csi pods will be collecting logs by the log rtoation setting, so even if its external mode turn on the log collector setting