search

red-hat-storage / ocs-operator

Operator for RHOCS
Apache License 2.0
86 stars 184 forks source link

Add a check for provider mode and pass to noobaa #2709

Closed bernerhat closed 1 month ago

bernerhat commented 1 month ago

Sets an annotation to noobaa cr if provider mode is enabled to allow pool ownership feature to be enabled. Part of Implement OCS and MCG operator support for pool ownership

leelavg commented 1 month ago

allow pool ownership feature to be enabled.

  • based on the annotation nb enables this feature? possible to refer corresponding PR in nb which implements this?
openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bernerhat, iamniting

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/red-hat-storage/ocs-operator/blob/main/OWNERS)~~ [iamniting] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ezio-auditore commented 1 week ago

/cherry-pick release-4.17

openshift-cherrypick-robot commented 1 week ago

@ezio-auditore: new pull request could not be created: failed to create pull request against red-hat-storage/ocs-operator#release-4.17 from head openshift-cherrypick-robot:cherry-pick-2709-to-release-4.17: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between red-hat-storage:release-4.17 and openshift-cherrypick-robot:cherry-pick-2709-to-release-4.17"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

In response to [this](https://github.com/red-hat-storage/ocs-operator/pull/2709#issuecomment-2326658595): >/cherry-pick release-4.17 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.