search

red-hat-storage / ocs-operator

Operator for RHOCS
Apache License 2.0
86 stars 184 forks source link

Expose storageCluster flag to allow updating of the OSD device classes #2711

Closed malayparida2000 closed 1 month ago

malayparida2000 commented 1 month ago

Earlier the device class of an OSD was determined at provisioning and it was not possible to update thereafter. In some scenarios the admin may want to force update the device class to a new value. To avoid accidental updates, rook requires first setting allowDeviceClassUpdate in the storage spec of the cephcluster for which we are exposing a new flag at Spec.ManagedResources.CephCluster.AllowDeviceClassUpdate.

context-https://github.com/rook/rook/pull/14457

malayparida2000 commented 1 month ago

@malayparida2000 better to have the generated crds, manifests change in a seperate commit?

Yeah kind off but as it's already LGTMed, I will let that pass to avoid another push & review.

travisn commented 1 month ago

/lgtm

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, malayparida2000, travisn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/red-hat-storage/ocs-operator/blob/main/OWNERS)~~ [iamniting] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
iamniting commented 1 month ago

/unhold