Open raaizik opened 1 month ago
/cc @nb-ohad
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: raaizik Once this PR has been reviewed and has the lgtm label, please ask for approval from iamniting. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
/test ocs-operator-bundle-e2e-aws
This feels like a complex hack to cause a panic without actually using
panic()
. How did we finalize on this approach?
@umangachapagain We do not need this approach at all, Me and Rewant tested the solution without any script and fixed the bugs we had and it works fine. They will soon update the PR.
/test ocs-operator-bundle-e2e-aws
/test ocs-operator-bundle-e2e-aws
@iamniting @umangachapagain This approach it not the approach that was discussed. We need to talk about this before merging this one.
/hold Adding a hold until we have a proper discussion and agreement on the approach
PR needs rebase.
Changes
ClusterClaim
,VolumeGroupSnapshotClass
andDRClusterConfig
).