Available CRDs check feature

red-hat-storage / ocs-operator

Operator for RHOCS

Apache License 2.0

86 stars 184 forks source link

Available CRDs check feature #2712

Open raaizik opened 1 month ago

raaizik commented 1 month ago

Changes

Adds a new controller that reacts whenever a create/delete event has been enqueued for a specific CRD that's become newly available.
Note: this PR introduces only the structure of the feature without any specific CRDs which will be added from their respective PRs (e.g., ClusterClaim, VolumeGroupSnapshotClass and DRClusterConfig).

raaizik commented 1 month ago

/cc @nb-ohad

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: raaizik Once this PR has been reviewed and has the lgtm label, please ask for approval from iamniting. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/red-hat-storage/ocs-operator/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

raaizik commented 1 month ago

/test ocs-operator-bundle-e2e-aws

iamniting commented 1 month ago

This feels like a complex hack to cause a panic without actually using panic(). How did we finalize on this approach?

@umangachapagain We do not need this approach at all, Me and Rewant tested the solution without any script and fixed the bugs we had and it works fine. They will soon update the PR.

raaizik commented 1 month ago

/test ocs-operator-bundle-e2e-aws

iamniting commented 1 month ago

/test ocs-operator-bundle-e2e-aws

nb-ohad commented 1 month ago

@iamniting @umangachapagain This approach it not the approach that was discussed. We need to talk about this before merging this one.

nb-ohad commented 1 month ago

/hold Adding a hold until we have a proper discussion and agreement on the approach

openshift-merge-robot commented 1 month ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.