search

red-hat-storage / ocs-operator

Operator for RHOCS
Apache License 2.0
86 stars 184 forks source link

provider: send csi-op APIs spec as part of gRPC response #2713

Closed leelavg closed 1 month ago

leelavg commented 1 month ago

client-operator needs two pieces of data among other things to configure csi-op (new) which inturn reconciles CSI.

The data required is Monitor IPs and names of CephBlockPoolRadosNamespace, CephFileSystemSubvolumeGroup. With this PR, the former will be sent via StorageConfig and latter names are via StorageClaimConfig, this helps client-operator to directly use these values rather than gluing the data from different gRPC responses.

leelavg commented 1 month ago

I'll split into commits when we are close to merge.

leelavg commented 1 month ago

/hold

nb-ohad commented 1 month ago

soft LGTM Waiting for @Madhu-1 to lgtm as well

Madhu-1 commented 1 month ago

Lgtm

leelavg commented 1 month ago

/unhold

nb-ohad commented 1 month ago

/lgtm

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leelavg, nb-ohad

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/red-hat-storage/ocs-operator/blob/main/OWNERS)~~ [nb-ohad] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
leelavg commented 4 weeks ago

/cherry-pick release-4.17

openshift-cherrypick-robot commented 4 weeks ago

@leelavg: new pull request created: #2746

In response to [this](https://github.com/red-hat-storage/ocs-operator/pull/2713#issuecomment-2285312738): >/cherry-pick release-4.17 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.