search

red-hat-storage / ocs-operator

Operator for RHOCS
Apache License 2.0
85 stars 184 forks source link

Read secrets for onboarding-token validation #2715

Closed Mrudraia closed 1 month ago

Mrudraia commented 4 months ago

This PR reads the secrets instead of reading the secrets from the volume mounts. whenever the new onboarding secrets are created, it takes more time to read the secrets from the volume mounts, The user clicks the rotate onboarding keys, the kubernetes still uses the old public, private keys , the new keys are mounted later, So this PR will read the secrets directly from the kubernetes secrets.

openshift-ci[bot] commented 4 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

rchikatw commented 4 months ago

Do you think it would be a good idea to remove the mounted secret from the ocs-operator? The mounted secret is used to create the default client. @leelavg

leelavg commented 4 months ago

Do you think it would be a good idea to remove the mounted secret from the ocs-operator? The mounted secret is used to create the default client. @leelavg

  • Sure, I see no point in having two implementations for the same requirement.
rchikatw commented 4 months ago

/retest

rchikatw commented 4 months ago

/test go test

openshift-ci[bot] commented 4 months ago

@rchikatw: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

Use /test all to run all jobs.

In response to [this](https://github.com/red-hat-storage/ocs-operator/pull/2715#issuecomment-2264919054): >/test go test Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
rchikatw commented 4 months ago

/test all

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Mrudraia Once this PR has been reviewed and has the lgtm label, please ask for approval from nb-ohad. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/red-hat-storage/ocs-operator/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
rchikatw commented 3 months ago

i see the rebase is not done properly. Can you rebase correctly? Basically, I see 2 commits and one of the commits is unrelated to your changes.

Mrudraia commented 2 months ago

@Mrudraia: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command ci/prow/ocs-operator-bundle-e2e-aws 496fd5e link unknown /test ocs-operator-bundle-e2e-aws Full PR test history. Your PR dashboard.

/retest

openshift-merge-robot commented 2 months ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
leelavg commented 2 months ago

Close this as a copy is raised already.

Nikhil-Ladha commented 1 month ago

Opened a new PR #2827