Open Mrudraia opened 1 month ago
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
Do you think it would be a good idea to remove the mounted secret from the ocs-operator? The mounted secret is used to create the default client. @leelavg
Do you think it would be a good idea to remove the mounted secret from the ocs-operator? The mounted secret is used to create the default client. @leelavg
- Sure, I see no point in having two implementations for the same requirement.
/retest
/test go test
@rchikatw: The specified target(s) for /test
were not found.
The following commands are available to trigger required jobs:
/test ci-bundle-ocs-operator-bundle
/test images
/test ocs-operator-bundle-e2e-aws
Use /test all
to run all jobs.
/test all
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Mrudraia Once this PR has been reviewed and has the lgtm label, please ask for approval from nb-ohad. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
i see the rebase is not done properly. Can you rebase correctly? Basically, I see 2 commits and one of the commits is unrelated to your changes.
@Mrudraia: The following test failed, say
/retest
to rerun all failed tests or/retest-required
to rerun all mandatory failed tests:Test name Commit Details Required Rerun command ci/prow/ocs-operator-bundle-e2e-aws 496fd5e link unknown
/test ocs-operator-bundle-e2e-aws
Full PR test history. Your PR dashboard.
/retest
This PR reads the secrets instead of reading the secrets from the volume mounts. whenever the new onboarding secrets are created, it takes more time to read the secrets from the volume mounts, The user clicks the rotate onboarding keys, the kubernetes still uses the old public, private keys , the new keys are mounted later, So this PR will read the secrets directly from the kubernetes secrets.