Closed OdedViner closed 2 weeks ago
Few questions/changes:
- Are all the permissions really needed? -> As you can see in the description of the PR, the testing process was serial and I checked the logs in ocs operator pod
- Please add a meaningful commit message to the commit. -> can you send me example
- Split the generated changes to a separate commit. -> got it
/retest
Please remove the bz number from the commit msg, let it be generic to the code.
Please remove the bz number from the commit msg, let it be generic to the code.
done
/retest
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: iamniting, Nikhil-Ladha, OdedViner
The full list of commands accepted by this bot can be found here.
The pull request process is described here