search

red-hat-storage / ocs-operator

Operator for RHOCS
Apache License 2.0
86 stars 184 forks source link

provider: add annotation to StorageCluster about deployment mode #2717

Closed leelavg closed 1 month ago

leelavg commented 1 month ago

setting an annotation on the storagecluster allows to only look at metadata for finding the configured mode rather than parsing the spec.

this helps for client-operator to decide reconciliation.

leelavg commented 1 month ago

/hold

for more testing

nb-ohad commented 1 month ago

LGTM, but prefer the @iamniting will also take a look

leelavg commented 1 month ago

/unhold

leelavg commented 1 month ago

/cherry-pick release-4.16

openshift-cherrypick-robot commented 1 month ago

@leelavg: once the present PR merges, I will cherry-pick it on top of release-4.16 in a new PR and assign it to you.

In response to [this](https://github.com/red-hat-storage/ocs-operator/pull/2717#issuecomment-2259609373): >/cherry-pick release-4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
leelavg commented 1 month ago

Tested as mentioned in https://github.com/red-hat-storage/ocs-client-operator/pull/196#issuecomment-2259679385

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, leelavg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/red-hat-storage/ocs-operator/blob/main/OWNERS)~~ [iamniting] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-cherrypick-robot commented 1 month ago

@leelavg: new pull request created: #2724

In response to [this](https://github.com/red-hat-storage/ocs-operator/pull/2717#issuecomment-2259609373): >/cherry-pick release-4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
leelavg commented 4 weeks ago

/cherry-pick release-4.17

openshift-cherrypick-robot commented 4 weeks ago

@leelavg: new pull request could not be created: failed to create pull request against red-hat-storage/ocs-operator#release-4.17 from head openshift-cherrypick-robot:cherry-pick-2717-to-release-4.17: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between red-hat-storage:release-4.17 and openshift-cherrypick-robot:cherry-pick-2717-to-release-4.17"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

In response to [this](https://github.com/red-hat-storage/ocs-operator/pull/2717#issuecomment-2285311057): >/cherry-pick release-4.17 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
leelavg commented 4 weeks ago

disregard.