Closed leelavg closed 1 month ago
/hold
for more testing
LGTM, but prefer the @iamniting will also take a look
/unhold
/cherry-pick release-4.16
@leelavg: once the present PR merges, I will cherry-pick it on top of release-4.16 in a new PR and assign it to you.
Tested as mentioned in https://github.com/red-hat-storage/ocs-client-operator/pull/196#issuecomment-2259679385
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: iamniting, leelavg
The full list of commands accepted by this bot can be found here.
The pull request process is described here
@leelavg: new pull request created: #2724
/cherry-pick release-4.17
@leelavg: new pull request could not be created: failed to create pull request against red-hat-storage/ocs-operator#release-4.17 from head openshift-cherrypick-robot:cherry-pick-2717-to-release-4.17: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between red-hat-storage:release-4.17 and openshift-cherrypick-robot:cherry-pick-2717-to-release-4.17"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}
disregard.
setting an annotation on the storagecluster allows to only look at metadata for finding the configured mode rather than parsing the spec.
this helps for client-operator to decide reconciliation.