search

red-hat-storage / ocs-operator

Operator for RHOCS
Apache License 2.0
85 stars 184 forks source link

Revert "Annotate RBD storageclasses for keyrotation" #2721

Closed black-dragon74 closed 3 months ago

black-dragon74 commented 4 months ago

This reverts commit e079940750ee2596cc8060fe286b768f14e65ea0.

We are not adding the annotation to storage classes by default in this release due to extra validations required to support only the vault KMS.

black-dragon74 commented 4 months ago

/retest failed

black-dragon74 commented 4 months ago

@malayparida2000 PTAL.

malayparida2000 commented 4 months ago

@malayparida2000 PTAL.

Can you add a bit more details about the reason for the revert both to the commit message/PR desc.

And the failing workflows was a github issue, I have reran all the workflows

black-dragon74 commented 3 months ago

@malayparida2000 shall I create a BZ for this?

Update: Bug 2303028 has been created for cherry-picking this onto 4.17

black-dragon74 commented 3 months ago

/cherrypick release-4.17

openshift-cherrypick-robot commented 3 months ago

@black-dragon74: once the present PR merges, I will cherry-pick it on top of release-4.17 in a new PR and assign it to you.

In response to [this](https://github.com/red-hat-storage/ocs-operator/pull/2721#issuecomment-2270328775): >/cherrypick release-4.17 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: black-dragon74, iamniting, malayparida2000

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/red-hat-storage/ocs-operator/blob/main/OWNERS)~~ [iamniting] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-cherrypick-robot commented 3 months ago

@black-dragon74: new pull request created: #2749

In response to [this](https://github.com/red-hat-storage/ocs-operator/pull/2721#issuecomment-2270328775): >/cherrypick release-4.17 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.