Closed vbnrh closed 1 month ago
/retitle Bug 2302448: Refactor imports in odfinfoconfig.go
@vbnrh: This pull request references Bugzilla bug 2302448, which is valid.
Requesting review from QA contact: /cc @PrasadDesala
@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: PrasadDesala.
Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.
Requesting review from QA contact: /cc @PrasadDesala
In response to [this](https://github.com/red-hat-storage/ocs-operator/pull/2729): >Bug 2302448: Refactor imports in odfinfoconfig.go Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Note: Move the BZ to Modified once after this PR is merged: https://github.com/red-hat-storage/ocs-operator/pull/2686, Otherwise it leads to FailedQA.
I checked the configMaps keys, it is just like what UI is expecting. Thanks!
/test ocs-operator-bundle-e2e-aws
/test ocs-operator-bundle-e2e-aws
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: umangachapagain, vbnrh
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/test ocs-operator-bundle-e2e-aws
/cherry-pick release-4.17
@agarwal-mudit: new pull request created: #2731
This change is required because 'sigs.k8s.io/yaml' produced a PascalCase output, which the UI cannot use. By using the new dependency 'gopkg.in/yaml.v2', we ensure the output is in camelCase, which the UI can use for its unmarshalling.
example output by
sigs.k8s.io/yaml
example output required by UI and done by 'gopkg.in/yaml.v2',