search

red-hat-storage / ocs-operator

Operator for RHOCS
Apache License 2.0
85 stars 184 forks source link

Bug 2302448: Refactor imports in odfinfoconfig.go #2729

Closed vbnrh closed 3 months ago

vbnrh commented 4 months ago

This change is required because 'sigs.k8s.io/yaml' produced a PascalCase output, which the UI cannot use. By using the new dependency 'gopkg.in/yaml.v2', we ensure the output is in camelCase, which the UI can use for its unmarshalling.

example output by sigs.k8s.io/yaml

Clients:
- ClusterID: cluster1
  Name: client1
- ClusterID: cluster2
  Name: client2
DeploymentType: internal
StorageCluster:
  CephClusterFSID: fsid12345
  NamespacedName:
    Name: storage-cluster
    Namespace: openshift-storage
  StorageProviderEndpoint: http://storage-provider-endpoint/
StorageSystemName: storage-system-1
Version: 4.17.0

example output required by UI and done by 'gopkg.in/yaml.v2',

version: 4.17.0
deploymentType: internal
clients:
- name: client1
  clusterId: cluster1
- name: client2
  clusterId: cluster2
storageCluster:
  namespacedName:
    namespace: openshift-storage
    name: storage-cluster
  storageProviderEndpoint: http://storage-provider-endpoint/
  cephClusterFSID: fsid12345
storageSystemName: storage-system-1
GowthamShanmugam commented 4 months ago

/retitle Bug 2302448: Refactor imports in odfinfoconfig.go

openshift-ci[bot] commented 4 months ago

@vbnrh: This pull request references Bugzilla bug 2302448, which is valid.

No validations were run on this bug

Requesting review from QA contact: /cc @PrasadDesala

In response to [this](https://github.com/red-hat-storage/ocs-operator/pull/2729): >Bug 2302448: Refactor imports in odfinfoconfig.go Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 4 months ago

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: PrasadDesala.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/red-hat-storage/ocs-operator/pull/2729#issuecomment-2264773116): >@vbnrh: This pull request references [Bugzilla bug 2302448](https://bugzilla.redhat.com/show_bug.cgi?id=2302448), which is valid. > >
No validations were run on this bug

Requesting review from QA contact: /cc @PrasadDesala

In response to [this](https://github.com/red-hat-storage/ocs-operator/pull/2729): >Bug 2302448: Refactor imports in odfinfoconfig.go Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

GowthamShanmugam commented 4 months ago

Note: Move the BZ to Modified once after this PR is merged: https://github.com/red-hat-storage/ocs-operator/pull/2686, Otherwise it leads to FailedQA.

GowthamShanmugam commented 4 months ago

I checked the configMaps keys, it is just like what UI is expecting. Thanks!

vbnrh commented 4 months ago

/test ocs-operator-bundle-e2e-aws

vbnrh commented 3 months ago

/test ocs-operator-bundle-e2e-aws

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: umangachapagain, vbnrh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/red-hat-storage/ocs-operator/blob/main/OWNERS)~~ [umangachapagain] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
vbnrh commented 3 months ago

/test ocs-operator-bundle-e2e-aws

agarwal-mudit commented 3 months ago

/cherry-pick release-4.17

openshift-cherrypick-robot commented 3 months ago

@agarwal-mudit: new pull request created: #2731

In response to [this](https://github.com/red-hat-storage/ocs-operator/pull/2729#issuecomment-2270579187): >/cherry-pick release-4.17 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.