search

red-hat-storage / ocs-operator

Operator for RHOCS
Apache License 2.0
86 stars 184 forks source link

update cephcsi pkg version #2744

Closed ShravaniVangur closed 3 weeks ago

ShravaniVangur commented 1 month ago

Previously, the security context constraints for rook-ceph-csi did not have RequiredDropCapabilities set. This commit updates the package information for ceph-csi security context which sets the RequiredDropCapabilites to ALL.

Output: oc describe scc rook-ceph-csi | grep " Required Drop Capabilities" Required Drop Capabilities: ALL

openshift-ci[bot] commented 1 month ago

@ShravaniVangur: This pull request references Bugzilla bug 2280637, which is valid.

No validations were run on this bug

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (ebenahar@redhat.com), skipping review request.

In response to [this](https://github.com/red-hat-storage/ocs-operator/pull/2744): >Bug 2280637: RequiredDropCapabilities set to ALL for rookcephcsi scc Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 1 month ago

Hi @ShravaniVangur. Thanks for your PR.

I'm waiting for a red-hat-storage member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
Nikhil-Ladha commented 1 month ago

/ok-to-test

Nikhil-Ladha commented 1 month ago

Please remove the bug name from the PR title. And, a description to the commit. Also, prefer not to capitalise first letter of the commit title.

Nikhil-Ladha commented 1 month ago

Also, can you please explain a bit more in the PR description as to why was this change needed?

openshift-ci[bot] commented 1 month ago

@ShravaniVangur: No Bugzilla bug is referenced in the title of this pull request. To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to [this](https://github.com/red-hat-storage/ocs-operator/pull/2744): >RequiredDropCapabilities set to ALL for rookcephcsi scc Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
Nikhil-Ladha commented 4 weeks ago

/retest

iamniting commented 4 weeks ago

/hold for @travisn or @Madhu-1 review

iamniting commented 3 weeks ago

/ok-to-test /unhold

ShravaniVangur commented 3 weeks ago

/retest

iamniting commented 3 weeks ago

/test ocs-operator-bundle-e2e-aws

openshift-ci[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, ShravaniVangur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/red-hat-storage/ocs-operator/blob/main/OWNERS)~~ [iamniting] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Nikhil-Ladha commented 3 weeks ago

/cherry-pick release-4.17

openshift-cherrypick-robot commented 3 weeks ago

@Nikhil-Ladha: new pull request created: #2752

In response to [this](https://github.com/red-hat-storage/ocs-operator/pull/2744#issuecomment-2298762330): >/cherry-pick release-4.17 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.