search

red-hat-storage / ocs-operator

Operator for RHOCS
Apache License 2.0
85 stars 184 forks source link

Allow osd crush reweight #2761

Closed parth-gr closed 2 months ago

parth-gr commented 3 months ago

From 4.17 there is setting introduced for upstream user, to allow if they want to add cutom weights,

For downstream always setting it true

Bug: https://bugzilla.redhat.com/show_bug.cgi?id=2307232

openshift-ci[bot] commented 3 months ago

@parth-gr: This pull request references Bugzilla bug 2307232, which is valid.

No validations were run on this bug

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (ikave@redhat.com), skipping review request.

In response to [this](https://github.com/red-hat-storage/ocs-operator/pull/2761): >Bug 2307232: Allow osd crush reweight Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
parth-gr commented 3 months ago

/assign @malayparida2000 @iamniting @travisn

parth-gr commented 3 months ago

/cherry-pick 4.17

openshift-cherrypick-robot commented 3 months ago

@parth-gr: once the present PR merges, I will cherry-pick it on top of 4.17 in a new PR and assign it to you.

In response to [this](https://github.com/red-hat-storage/ocs-operator/pull/2761#issuecomment-2309852011): >/cherry-pick 4.17 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 3 months ago

@parth-gr: No Bugzilla bug is referenced in the title of this pull request. To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to [this](https://github.com/red-hat-storage/ocs-operator/pull/2761): >Allow osd crush reweight Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
parth-gr commented 3 months ago

By Malay: Rook latest is bringing k8s 1.31.0. That's forcing us to bring up controller runtime to 1.19.0 due to some dependancies. After that controller runtime 1.19.0 runs into issue with OLM 1.28.0 as they are using k8 1.30 something. Normally this doesn't happen but k8s 1.31.0 has some breaking issues coming from 1.30, the same with controller runtime 1.19.0

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, parth-gr, travisn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/red-hat-storage/ocs-operator/blob/main/OWNERS)~~ [iamniting,travisn] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-cherrypick-robot commented 2 months ago

@parth-gr: cannot checkout 4.17: error checking out "4.17": exit status 1 error: pathspec '4.17' did not match any file(s) known to git

In response to [this](https://github.com/red-hat-storage/ocs-operator/pull/2761#issuecomment-2309852011): >/cherry-pick 4.17 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
parth-gr commented 2 months ago

/cherry-pick release-4.17

openshift-cherrypick-robot commented 2 months ago

@parth-gr: new pull request created: #2778

In response to [this](https://github.com/red-hat-storage/ocs-operator/pull/2761#issuecomment-2324756519): > >/cherry-pick release-4.17 > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.