search

red-hat-storage / ocs-operator

Operator for RHOCS
Apache License 2.0
85 stars 184 forks source link

use qualified name upto ".svc" for endpoint svc in native storageclient #2766

Closed leelavg closed 2 months ago

leelavg commented 3 months ago

cluster proxies are configured not to proxy in cluster traffic and since we were using only the service name the connection is being proxied, using a qualified name upto ".svc" or ".svc.cluster.local" which is already configured under .spec.noProxy in proxy/cluster resource doesn't proxy the connection.

leelavg commented 3 months ago

/cherry-pick release-4.17 https://bugzilla.redhat.com/show_bug.cgi?id=2307823

openshift-cherrypick-robot commented 3 months ago

@leelavg: once the present PR merges, I will cherry-pick it on top of release-4.17 in a new PR and assign it to you.

In response to [this](https://github.com/red-hat-storage/ocs-operator/pull/2766#issuecomment-2316807473): >/cherry-pick release-4.17 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
leelavg commented 3 months ago

/cherry-pick release-4.16 https://bugzilla.redhat.com/show_bug.cgi?id=2308445

openshift-cherrypick-robot commented 3 months ago

@leelavg: once the present PR merges, I will cherry-pick it on top of release-4.16 in a new PR and assign it to you.

In response to [this](https://github.com/red-hat-storage/ocs-operator/pull/2766#issuecomment-2316808392): >/cherry-pick release-4.16 >https://bugzilla.redhat.com/show_bug.cgi?id=2308445 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
nb-ohad commented 2 months ago

/lgtm

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leelavg, nb-ohad

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/red-hat-storage/ocs-operator/blob/main/OWNERS)~~ [nb-ohad] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-cherrypick-robot commented 2 months ago

@leelavg: new pull request created: #2780

In response to [this](https://github.com/red-hat-storage/ocs-operator/pull/2766#issuecomment-2316807473): >/cherry-pick release-4.17 >https://bugzilla.redhat.com/show_bug.cgi?id=2307823 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-cherrypick-robot commented 2 months ago

@leelavg: new pull request created: #2781

In response to [this](https://github.com/red-hat-storage/ocs-operator/pull/2766#issuecomment-2316808392): >/cherry-pick release-4.16 >https://bugzilla.redhat.com/show_bug.cgi?id=2308445 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.