Closed rewantsoni closed 2 months ago
Testing:
[rewantsoni odf] k get storagecluster ocs-storagecluster -oyaml | yq '.spec.mirroring' && k get cephblockpool ocs-storagecluster-cephblockpool -oyaml | yq '.spec.mirroring'
null
{}
Enabled from storageCluster:
[rewantsoni odf] k get storagecluster ocs-storagecluster -oyaml | yq '.spec.mirroring' && echo "" && k get cephblockpool ocs-storagecluster-cephblockpool -oyaml | yq '.spec.mirroring'
enabled: true
peerSecretNames:
- ux-cert-secret
enabled: true
mode: image
peers:
secretNames:
- ux-cert-secret
Disable from storageCluster:
[rewantsoni odf] k get storagecluster ocs-storagecluster -oyaml | yq '.spec.mirroring' && echo "" && k get cephblockpool ocs-storagecluster-cephblockpool -oyaml | yq '.spec.mirroring'
enabled: false
{}
Not set on storageCluster:
[rewantsoni odf] k get storagecluster ocs-storagecluster -oyaml | yq '.spec.mirroring' && echo "" && k get cephblockpool ocs-storagecluster-cephblockpool -oyaml | yq '.spec.mirroring'
null
enabled: true
mode: image
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: iamniting, rewantsoni
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/cherry-pick release-4.17
@rewantsoni: new pull request created: #2796
When mirroring on storageCluster was disabled, the cephblockpool mirroring was not disabled, this could break the DR as MCO enables/disables the mirroring on the cephblockpool via storageCluster.
Hence, with this PR we are making the mirroring spec on the storageCluster as a pointer and enabling/disabling mirroring on cephblockpool only if the value is set. If mirroring is set to nil other controller will be able to make changes on the mirroring field on the cephblockpool.