search

red-hat-storage / ocs-operator

Operator for RHOCS
Apache License 2.0
85 stars 184 forks source link

restore default affinity for noobaa standalone #2797

Closed jackyalbo closed 2 months ago

jackyalbo commented 2 months ago

Fix for https://bugzilla.redhat.com/show_bug.cgi?id=2311551

We revert the nodeAffinity change to apply only to cases where users explicitly set nodeAffinity in storage cluster spec.

openshift-ci[bot] commented 2 months ago

Hi @jackyalbo. Thanks for your PR.

I'm waiting for a red-hat-storage member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
jackyalbo commented 2 months ago

/retest-required

openshift-ci[bot] commented 2 months ago

@jackyalbo: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/red-hat-storage/ocs-operator/pull/2797#issuecomment-2352699547): >/retest-required Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
malayparida2000 commented 2 months ago

/ok-to-test

malayparida2000 commented 2 months ago

/retest

malayparida2000 commented 2 months ago

Please fix the failing unit test here https://github.com/red-hat-storage/ocs-operator/blob/6cbff2ce33ef6e58c5a3a1e4c38f92a6f6dbc80d/controllers/storagecluster/noobaa_system_reconciler_test.go#L284

https://github.com/red-hat-storage/ocs-operator/blob/6cbff2ce33ef6e58c5a3a1e4c38f92a6f6dbc80d/controllers/storagecluster/noobaa_system_reconciler_test.go#L376

malayparida2000 commented 2 months ago

@jackyalbo is this a direct revert of this https://github.com/red-hat-storage/ocs-operator/pull/2461?

jackyalbo commented 2 months ago

@jackyalbo is this a direct revert of this #2461? No. I still want Affinity to be set in standalone but only if it is set in storageCluster spec( the ok check). I'm trying not to hurt the flow for non-standalone - which failed the unit test.

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackyalbo, malayparida2000, umangachapagain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/red-hat-storage/ocs-operator/blob/main/OWNERS)~~ [umangachapagain] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
malayparida2000 commented 2 months ago

/retest

malayparida2000 commented 2 months ago

/cherry-pick release-4.17

openshift-cherrypick-robot commented 2 months ago

@malayparida2000: once the present PR merges, I will cherry-pick it on top of release-4.17 in a new PR and assign it to you.

In response to [this](https://github.com/red-hat-storage/ocs-operator/pull/2797#issuecomment-2354733763): >/cherry-pick release-4.17 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-cherrypick-robot commented 2 months ago

@malayparida2000: new pull request created: #2801

In response to [this](https://github.com/red-hat-storage/ocs-operator/pull/2797#issuecomment-2354733763): >/cherry-pick release-4.17 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.