search

red-hat-storage / ocs-operator

Operator for RHOCS
Apache License 2.0
85 stars 184 forks source link

remove resource limits on ocs-metrics-exporter #2813

Closed weirdwiz closed 2 months ago

weirdwiz commented 2 months ago

removing the limits on ocs-metrics-exporter, the in memory cache scales with the amount of PVs in the cluster making it hard to point out an upper limit for the memory.

Signed-off-by: Divyansh Kamboj dkamboj@redhat.com

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: umangachapagain, weirdwiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/red-hat-storage/ocs-operator/blob/main/OWNERS)~~ [umangachapagain] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
weirdwiz commented 2 months ago

/cherry-pick release-4.17

openshift-cherrypick-robot commented 2 months ago

@weirdwiz: once the present PR merges, I will cherry-pick it on top of release-4.17 in a new PR and assign it to you.

In response to [this](https://github.com/red-hat-storage/ocs-operator/pull/2813#issuecomment-2363002003): > >/cherry-pick release-4.17 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
weirdwiz commented 2 months ago

/test ocs-operator-bundle-e2e-aws

openshift-cherrypick-robot commented 2 months ago

@weirdwiz: new pull request created: #2814

In response to [this](https://github.com/red-hat-storage/ocs-operator/pull/2813#issuecomment-2363002003): > >/cherry-pick release-4.17 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.