search

red-hat-storage / ocs-operator

Operator for RHOCS
Apache License 2.0
85 stars 184 forks source link

rbd: Allow user to disable key rotation #2817

Closed black-dragon74 closed 1 week ago

black-dragon74 commented 2 months ago

This patch allows user to disable automatic key rotation by annotating StorageCluster with keyrotation.csiaddons.openshift.io/enable=false

black-dragon74 commented 3 weeks ago

I think we dont have code that updates the storageclass, can you please check/test what happens if we add/remove the annotation?

Right. I have updated the PR to recreate the storage class in cases where the existing StorageClass does not have the annotation present.

Madhu-1 commented 2 weeks ago

/assign @iamniting

openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: black-dragon74, iamniting, Madhu-1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/red-hat-storage/ocs-operator/blob/main/OWNERS)~~ [iamniting] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
iamniting commented 2 weeks ago

@black-dragon74 Have you tested it? If not pls add a hold on the PR and test it before it gets merged.

black-dragon74 commented 2 weeks ago

@black-dragon74 Have you tested it? If not pls add a hold on the PR and test it before it gets merged.

I tested an older version of this PR. The core implementation did not change. I am putting a hold, will cancel it once I test it out.

/hold

iamniting commented 2 weeks ago

@black-dragon74 Have you tested it? If not pls add a hold on the PR and test it before it gets merged.

I tested an older version of this PR. The core implementation did not change. I am putting a hold, will cancel it once I test it out.

/hold

Thanks

black-dragon74 commented 1 week ago

Tested with the latest set of changes. Everything is working as expected.

/hold cancel