Prevent noobaaccount creation in provider cluster

red-hat-storage / ocs-operator

Operator for RHOCS

Apache License 2.0

85 stars 184 forks source link

Prevent noobaaccount creation in provider cluster #2819

Closed ezio-auditore closed 1 month ago

ezio-auditore commented 2 months ago

Since a provider cluster already has a NooBaa system and does not require a NooBaa account to connect to a remote cluster, unlike client clusters. A NooBaa account only needs to be created if the storage consumer is for a client cluster. Changes in this PR -

Ignore Creation of noobaa account if cluster is a provider cluster by match cluster id
Ignore adding noobaa resources to Storage config if on provider cluster

openshift-ci[bot] commented 2 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ezio-auditore, iamniting

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/red-hat-storage/ocs-operator/blob/main/OWNERS)~~ [iamniting] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

iamniting commented 1 month ago

looks good to me. \hold for @nb-ohad

looks like I added the \ instead of / and the PR is merged without Ohad's review.

ezio-auditore commented 1 month ago

/cherry-pick release-4.17

openshift-cherrypick-robot commented 1 month ago

@ezio-auditore: new pull request created: #2824

In response to [this](https://github.com/red-hat-storage/ocs-operator/pull/2819#issuecomment-2382165822): >/cherry-pick release-4.17 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.