search

red-hat-storage / ocs-operator

Operator for RHOCS
Apache License 2.0
85 stars 184 forks source link

Remove healthchecker ceph client #2838

Closed ezio-auditore closed 1 week ago

ezio-auditore commented 1 month ago

Solves: https://github.com/red-hat-storage/ocs-operator/issues/2829

openshift-ci[bot] commented 1 month ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

ezio-auditore commented 1 month ago

/test all

ezio-auditore commented 1 month ago

/test verify generated changes (1.22)

openshift-ci[bot] commented 1 month ago

@ezio-auditore: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

Use /test all to run all jobs.

In response to [this](https://github.com/red-hat-storage/ocs-operator/pull/2838#issuecomment-2391503814): >/test verify generated changes (1.22) Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
ezio-auditore commented 1 month ago

/assign @Madhu-1

ezio-auditore commented 1 month ago

/hold for testing

ezio-auditore commented 1 month ago

/unhold verified

ezio-auditore commented 1 month ago

/test ocs-operator-bundle-e2e-aws

ezio-auditore commented 1 month ago

/unhold

rewantsoni commented 1 month ago

The changes look good, just wondering if we should update the name for setCephResourceStatus method and CephResources field in the StorageConsumer Status to reflect that they can be any kind of Resources (NoobaaAccount or any other fields we might want to add in future)

ezio-auditore commented 1 month ago

The changes look good, just wondering if we should update the name for setCephResourceStatus method and CephResources field in the StorageConsumer Status to reflect that they can be any kind of Resources (NoobaaAccount or any other fields we might want to add in future)

@rewantsoni Yes I agree the name should be changed from CephResources to GenericResources or some other name to clearly justify the need and the purpose of the field.

ezio-auditore commented 1 month ago

/test ocs-operator-bundle-e2e-aws

Madhu-1 commented 1 month ago

The changes look good, just wondering if we should update the name for setCephResourceStatus method and CephResources field in the StorageConsumer Status to reflect that they can be any kind of Resources (NoobaaAccount or any other fields we might want to add in future)

@rewantsoni Yes I agree the name should be changed from CephResources to GenericResources or some other name to clearly justify the need and the purpose of the field.

This might need API change as API is tied to the CephResource name

ezio-auditore commented 1 month ago

/test ocs-operator-bundle-e2e-aws

ezio-auditore commented 2 weeks ago

/assign @iamniting

openshift-ci[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ezio-auditore, iamniting

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/red-hat-storage/ocs-operator/blob/main/OWNERS)~~ [iamniting] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment