search

red-hat-storage / ocs-operator

Operator for RHOCS
Apache License 2.0
85 stars 184 forks source link

onboardingTicket: add uid to the ticket #2844

Closed rewantsoni closed 3 weeks ago

rewantsoni commented 1 month ago

onboarding ticket should contain the storageCluster UID the token was generated for and to fetch the storageCluster for UID, we fetch the storage Cluster from operator namespace

mrudraia1 commented 1 month ago

I faced storagecluster UID error while testing the PR 2827. The PR 2827 can be tested after this PR is merged.

rewantsoni commented 1 month ago

@rewantsoni You are in the context of handling the message, please follow the proper way to write into the response stream (w.WriteHeader), and use a proper HTTP response code @nb-ohad http.Error is a helper function that sets the error code on the header and sets the response. See here

rewantsoni commented 1 month ago

@rewantsoni You are in the context of handling the message, please follow the proper way to write into the response stream (w.WriteHeader), and use a proper HTTP response code @nb-ohad http.Error is a helper function that sets the error code on the header and sets the response. See here

nb-ohad commented 3 weeks ago

/lgtm

openshift-ci[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nb-ohad, rewantsoni

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/red-hat-storage/ocs-operator/blob/main/OWNERS)~~ [nb-ohad] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment