search

red-hat-storage / ocs-operator

Operator for RHOCS
Apache License 2.0
85 stars 184 forks source link

Fix broken watch for CRDs on storageCluster controller #2872

Open malayparida2000 opened 2 weeks ago

malayparida2000 commented 2 weeks ago

The watch had builder.WithPredicates twice, which was causing the watch to not work as expected. Thus even after the CRD was created the controller was not able to detect it and queue a reconcile. Now the predicates are combined under one builder.WithPredicates.

openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: malayparida2000 Once this PR has been reviewed and has the lgtm label, please assign obnoxxx for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/red-hat-storage/ocs-operator/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment