red-hat-storage / ocs-operator

Operator for RHOCS
Apache License 2.0
85 stars 184 forks source link

controllers: add a new controller to setup mirroring #2878

Closed rewantsoni closed 1 day ago

rewantsoni commented 3 weeks ago

Add two rpc calls required for setting up mirroring for blockpool and radosnamespace

  1. GetBlockPoolsInfo
  2. GetClientInfo

A new controller to enable mirroring for cephblockpool and radosnamespace

Depends On:

  1. https://github.com/red-hat-storage/ocs-operator/pull/2675
openshift-ci[bot] commented 3 weeks ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

nb-ohad commented 1 day ago

/lgtm

openshift-ci[bot] commented 1 day ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nb-ohad, rewantsoni

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/red-hat-storage/ocs-operator/blob/main/OWNERS)~~ [nb-ohad] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
rewantsoni commented 1 day ago

/jira backport release-4.18

openshift-ci-robot commented 1 day ago

@rewantsoni: The following backport issues have been created:

Queuing cherrypicks to the requested branches to be created after this PR merges: /cherrypick release-4.18

In response to [this](https://github.com/red-hat-storage/ocs-operator/pull/2878#issuecomment-2500428278): >/jira backport release-4.18 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=red-hat-storage%2Focs-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-cherrypick-robot commented 1 day ago

@openshift-ci-robot: once the present PR merges, I will cherry-pick it on top of release-4.18 in a new PR and assign it to you.

In response to [this](https://github.com/red-hat-storage/ocs-operator/pull/2878#issuecomment-2500428433): >@rewantsoni: The following backport issues have been created: > > >Queuing cherrypicks to the requested branches to be created after this PR merges: >/cherrypick release-4.18 > >
> >In response to [this](https://github.com/red-hat-storage/ocs-operator/pull/2878#issuecomment-2500428278): > >>/jira backport release-4.18 > > >Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=red-hat-storage%2Focs-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository. >

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-cherrypick-robot commented 1 day ago

@openshift-ci-robot: new pull request created: #2908

In response to [this](https://github.com/red-hat-storage/ocs-operator/pull/2878#issuecomment-2500428433): >@rewantsoni: The following backport issues have been created: > > >Queuing cherrypicks to the requested branches to be created after this PR merges: >/cherrypick release-4.18 > >
> >In response to [this](https://github.com/red-hat-storage/ocs-operator/pull/2878#issuecomment-2500428278): > >>/jira backport release-4.18 > > >Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=red-hat-storage%2Focs-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository. >

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.